Skip to content

e2e: add variable-guest-policy test#2324

Merged
charludo merged 2 commits intoch/variable-guest-policyfrom
ch/e2e/variable-guest-policy
Apr 21, 2026
Merged

e2e: add variable-guest-policy test#2324
charludo merged 2 commits intoch/variable-guest-policyfrom
ch/e2e/variable-guest-policy

Conversation

@charludo
Copy link
Copy Markdown
Collaborator

No description provided.

@charludo charludo added the no changelog PRs not listed in the release notes label Apr 16, 2026
@charludo charludo requested a review from burgerdev April 16, 2026 15:09
@katexochen
Copy link
Copy Markdown
Member

Adding a separate e2e test is expensive, maybe this could be added to the attestation e2e?

@charludo
Copy link
Copy Markdown
Collaborator Author

Adding a separate e2e test is expensive, maybe this could be added to the attestation e2e?

Sounds good.

Comment thread e2e/variable-guest-policy/variable-guest-policy_test.go Outdated
Comment thread e2e/variable-guest-policy/variable-guest-policy_test.go Outdated
@katexochen katexochen assigned charludo and katexochen and unassigned charludo Apr 20, 2026
@charludo charludo force-pushed the ch/e2e/variable-guest-policy branch from d4790e9 to d248366 Compare April 20, 2026 13:48
@charludo charludo requested a review from katexochen April 20, 2026 14:50
@katexochen
Copy link
Copy Markdown
Member

test wasn't triggered in CI, could you add another commit with a pr trigger for it?

@charludo
Copy link
Copy Markdown
Collaborator Author

charludo commented Apr 21, 2026

@katexochen not sure if this is really needed on every PR

@katexochen
Copy link
Copy Markdown
Member

not sure if this is really needed on every PR

not on every PR, but I would run it on every PR that touches the attestation e2e test at least.

@charludo
Copy link
Copy Markdown
Collaborator Author

@katexochen OK, nevermind.. We're already doing this for other tests, I see. Added the workflow, but also the ticket to rework this somehow 😅

@charludo charludo force-pushed the ch/e2e/variable-guest-policy branch from 605f57d to 91623db Compare April 21, 2026 13:28
@charludo charludo merged commit 63e851e into ch/variable-guest-policy Apr 21, 2026
17 checks passed
@charludo charludo deleted the ch/e2e/variable-guest-policy branch April 21, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PRs not listed in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants